[PATCH] D24595: [lib/LTO] Remove now unneded hack for undefined symbols

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 18:06:10 PDT 2016


pcc added inline comments.

================
Comment at: lib/LTO/LTO.cpp:390
@@ -388,3 +389,3 @@
   auto ResI = Res.begin();
   for (const InputFile::Symbol &Sym : Input->symbols()) {
     assert(ResI != Res.end());
----------------
davide wrote:
> mehdi_amini wrote:
> > We should have the same assert in this loop (maybe in a separate patch)
> Oh, sure :) I'm still not very familiar with Thin so I didn't think about it. Thanks!
Or you could add it to `addSymbolToGlobalRes`.


https://reviews.llvm.org/D24595





More information about the llvm-commits mailing list