[PATCH] D24595: [lib/LTO] Remove now unneded hack for undefined symbols

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/LTO/LTO.cpp:359
@@ -357,3 +358,3 @@
     // what is the "right" behavior here.
     if (Sym.getFlags() & object::BasicSymbolRef::SF_Common) {
       auto &CommonRes = RegularLTO.Commons[Sym.getIRName()];
----------------
mehdi_amini wrote:
> Is this ok with  `Sym.getFlags() & object::BasicSymbolRef::SF_Undefined`?
> The `continue;` you're removing makes us no longer short-circuiting this code.
I guess we can't have Common and undefined at the same time...


https://reviews.llvm.org/D24595