[llvm] r281483 - MCInstrDesc: this fixes an issue setting/getting member Flags, which
Sjoerd Meijer via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 07:32:17 PDT 2016
Author: sjoerdmeijer
Date: Wed Sep 14 09:32:17 2016
New Revision: 281483
URL: http://llvm.org/viewvc/llvm-project?rev=281483&view=rev
Log:
MCInstrDesc: this fixes an issue setting/getting member Flags, which
is an uint64_t. However, getter function getFlags returned an unsigned,
and in function hasProperty (1 << MCFlag) was used instead of (1ULL << MCFlag).
Modified:
llvm/trunk/include/llvm/CodeGen/MachineInstr.h
llvm/trunk/include/llvm/MC/MCInstrDesc.h
Modified: llvm/trunk/include/llvm/CodeGen/MachineInstr.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineInstr.h?rev=281483&r1=281482&r2=281483&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineInstr.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineInstr.h Wed Sep 14 09:32:17 2016
@@ -391,10 +391,10 @@ public:
bool hasProperty(unsigned MCFlag, QueryType Type = AnyInBundle) const {
// Inline the fast path for unbundled or bundle-internal instructions.
if (Type == IgnoreBundle || !isBundled() || isBundledWithPred())
- return getDesc().getFlags() & (1 << MCFlag);
+ return getDesc().getFlags() & (1ULL << MCFlag);
// If this is the first instruction in a bundle, take the slow path.
- return hasPropertyInBundle(1 << MCFlag, Type);
+ return hasPropertyInBundle(1ULL << MCFlag, Type);
}
/// Return true if this instruction can have a variable number of operands.
Modified: llvm/trunk/include/llvm/MC/MCInstrDesc.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCInstrDesc.h?rev=281483&r1=281482&r2=281483&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCInstrDesc.h (original)
+++ llvm/trunk/include/llvm/MC/MCInstrDesc.h Wed Sep 14 09:32:17 2016
@@ -216,7 +216,7 @@ public:
unsigned getNumDefs() const { return NumDefs; }
/// \brief Return flags of this instruction.
- unsigned getFlags() const { return Flags; }
+ uint64_t getFlags() const { return Flags; }
/// \brief Return true if this instruction can have a variable number of
/// operands. In this case, the variable operands will be after the normal
More information about the llvm-commits
mailing list