[PATCH] D21409: Emit a swap for STXVD2X when it's emitted by matching a 'store' node

[Nemanja Ivanovic via llvm-commits]

nemanjai added a comment.

In https://reviews.llvm.org/D21409#530485, @kbarton wrote:

> Test case?


There is currently no known way to actually hit this code. This was initially proposed as a fix for a bug in which an invalid optimization left the store node past the DAG combine phase so we matched the node to the SDAG ISel pattern.
When everything is working correctly, there is no way to actually get to the DAG ISel with this node so this pattern should never be matched. However, the pattern is indeed incorrect on little endian platforms.

I can abandon this revision if we choose to leave this pattern in, but ultimately it is incorrect and I would argue that it'd be better to not have it (and crash if we get here) than it is to have an incorrect one.


Repository:
  rL LLVM

https://reviews.llvm.org/D21409