[PATCH] D24435: Delete more dead code in SelectionDAG (NFC)

[Simon Pilgrim via llvm-commits]

RKSimon added a comment.

As per Mehdi's suggestion - please ask on the llvm-dev list for somebody downstream to take ownership of TargetIndexSDNode/getTargetIndex and improve testing. Otherwise it shouldn't be left to rot in trunk (but that should be a separate patch).

The rest of the patch looks alright.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:656
@@ -655,3 +655,1 @@
 
-  unsigned getSDNodeOrder() const { return SDNodeOrder; }
-
----------------
vsk wrote:
> RKSimon wrote:
> > Do you know the history behind this and DanglingDebugInfo::getSDNodeOrder()?
> No, I don't. Is this something we're better off keeping?
No, I think it can go.


https://reviews.llvm.org/D24435