[PATCH] D24435: Delete more dead code in SelectionDAG (NFC)

[Justin Bogner via llvm-commits]

Mehdi AMINI <mehdi.amini at apple.com> writes:
> mehdi_amini added inline comments.
>
> ================
> Comment at: include/llvm/CodeGen/SelectionDAG.h:561
> @@ -560,3 +560,1 @@
> -  SDValue getTargetIndex(int Index, EVT VT, int64_t Offset = 0,
> -                         unsigned char TargetFlags = 0);
>    // When generating a branch to a BB, we don't in general know enough
> ----------------
> vsk wrote:
>> RKSimon wrote:
>> > This should stay while TargetIndexSDNode exists.
>> > 
>> > However, TargetIndexSDNode doesn't appear to be used so maybe
>> > start a conversion on llvm-dev about removing it and if successful
>> > then propose a separate patch?
>> It looks like this code has out of tree users (see r250717), so I
>> won't mess with it.
> If there are out-of-tree users that care about having this API
> upstream, they should provide coverage testing for it, otherwise this
> can live in the downstream codebase...

It's unfortunate that there isn't proper testing of this in tree - I'll
try to see about remedying that in the near future.

However, this has been like this for years and there are definitely
downstream users at this point, so removing it would be pretty
unfortunate.