[PATCH] D24367: [llvm-cov] Provided easy navigation to find the previous and next report.
Ying Yi via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 13 07:42:39 PDT 2016
MaggieYi marked 2 inline comments as done.
================
Comment at: test/tools/llvm-cov/showProjectSummary.cpp:39
@@ -38,2 +38,3 @@
// HTML: <span>Created:
+// HTML_NAVIGATION: <a href='../../index.html'>Index</a> | Prev | Next<br>
// HTML-FILE: <pre>Source: {{.*}}showProjectSummary.cpp (Binary: showProjectSummary.covmapping)</pre>
----------------
vsk wrote:
> vsk wrote:
> > I don't think we should display "Prev" or "Next" if they aren't links.
> We're missing tests for the case where there is a prev link but no next link, and a next link but no prev link. Maybe you could reuse the multiple-inputs.covmapping file to test this?
Thanks, I have followed your advice to add the missing tests.
https://reviews.llvm.org/D24367
More information about the llvm-commits
mailing list