[PATCH] D24367: [llvm-cov] Provided easy navigation to find the previous and next report.

[Ying Yi via llvm-commits]

MaggieYi updated this revision to Diff 71164.
MaggieYi added a comment.

In https://reviews.llvm.org/D24367#539047, @vsk wrote:

> On a low level, I'm concerned about the unnecessary quadratic behavior in this patch. If "N = |SourceFiles|", then renderPageNavigation() does O(N) work and it's called O(N) times. Given that llvm+clang has over 2,400 source files, this could actually be noticeable. We already get user reports about llvm-cov being slow...


Thanks for pointing this out. I have updated the patch and removed unnecessary execution time in the renderPageNavigation() function. After reducing the cost of running time, will it be considered as an acceptable feature?

> On a high level, I'm not convinced that this is a significant usability improvement (as opposed to the "Go to first unexecuted line" feature). You can emulate this functionality by clicking the "Back" button in your browser and picking the next interesting file. Note that users are generally uninterested in looking at the coverage report for *every* file -- they usually just care about the ones with low coverage.


I will add filter and sort table functions to the index page to only show the source files that the users are interested in. In the long term, the previous and next links could then automatically update when using the filter function.


https://reviews.llvm.org/D24367

Files:
  test/tools/llvm-cov/f1.c
  test/tools/llvm-cov/f2.c
  test/tools/llvm-cov/f3.c
  test/tools/llvm-cov/showProjectSummary.cpp
  tools/llvm-cov/CodeCoverage.cpp
  tools/llvm-cov/CoverageViewOptions.h
  tools/llvm-cov/SourceCoverageView.cpp
  tools/llvm-cov/SourceCoverageView.h
  tools/llvm-cov/SourceCoverageViewHTML.cpp
  tools/llvm-cov/SourceCoverageViewHTML.h
  tools/llvm-cov/SourceCoverageViewText.cpp
  tools/llvm-cov/SourceCoverageViewText.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24367.71164.patch
Type: text/x-patch
Size: 14502 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160913/6357a9b9/attachment.bin>