[PATCH] D24386: Store an ArrayRef for Data in InputSectionData

[Rafael Espíndola via llvm-commits]

On 9 September 2016 at 13:46, Rui Ueyama <ruiu at google.com> wrote:
> ruiu added inline comments.
>
> ================
> Comment at: ELF/InputSection.cpp:34
> @@ +33,3 @@
> +                                            const typename ELFT::Shdr *Hdr) {
> +  if (!File || Hdr->sh_type == SHT_NOBITS)
> +    return ArrayRef<uint8_t>();
> ----------------
> Can File be null?

Yes, dummy section (like the one for common) use a null file.

> ================
> Comment at: ELF/InputSection.cpp:35
> @@ +34,3 @@
> +  if (!File || Hdr->sh_type == SHT_NOBITS)
> +    return ArrayRef<uint8_t>();
> +  return check(File->getObj().getSectionContents(Hdr));
> ----------------
>   return {};

Will do.

Cheers,
Rafael