[PATCH] D24386: Store an ArrayRef for Data in InputSectionData

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.cpp:34
@@ +33,3 @@
+                                            const typename ELFT::Shdr *Hdr) {
+  if (!File || Hdr->sh_type == SHT_NOBITS)
+    return ArrayRef<uint8_t>();
----------------
Can File be null?

================
Comment at: ELF/InputSection.cpp:35
@@ +34,3 @@
+  if (!File || Hdr->sh_type == SHT_NOBITS)
+    return ArrayRef<uint8_t>();
+  return check(File->getObj().getSectionContents(Hdr));
----------------
  return {};


https://reviews.llvm.org/D24386