[PATCH] D24354: cmake: Install the OCaml libraries into a more correct path

JacquesPa via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 13:45:11 PDT 2016


jpdeplaix added a comment.

In https://reviews.llvm.org/D24354#537592, @mgorny wrote:

> Is there a reason to use multiple META.* files then? Considering that installing the files in a subdirectory is necessary anyway, I think it might be cleaner to just combine and install one META file for all of them. This will also make the logic simpler since it would be limited to a single flexible installation path with no need to reference parent/subdirectory structure.
>
> Of course, another option is to just make the top directory configurable, and always create 'llvm' in it. I think this is the solution you were proposing, correct?


It is cleaner I agree, but it breaks backward compatibility. So I would say it should stay as is.
And yes I think the best solution would be to make the top directory configurable, to install the METAs in it and to install the rest in the 'llvm' subdir. That would be perfect ! :)


https://reviews.llvm.org/D24354





More information about the llvm-commits mailing list