[PATCH] D24354: cmake: Install the OCaml libraries into a more correct path

[Michał Górny via llvm-commits]

mgorny planned changes to this revision.
mgorny added a comment.

In https://reviews.llvm.org/D24354#537571, @jpdeplaix wrote:

> ocamlfind is looking for a "META" file in subdirectories so META.llvm (for example) is not handled.
>  META files in the form "META.thing" are handled only in the base directory.


Thanks for explaning this. I was confused because other packages installed META files in the subdirectories.

Is there a reason to use multiple META.* files then? Considering that installing the files in a subdirectory is necessary anyway, I think it might be cleaner to just combine and install one META file for all of them. This will also make the logic simpler since it would be limited to a single flexible installation path with no need to reference parent/subdirectory structure.

Of course, another option is to just make the top directory configurable, and always create 'llvm' in it. I think this is the solution you were proposing, correct?


https://reviews.llvm.org/D24354