[lld] r280947 - Handle globs in global symbol names.

[Rui Ueyama via llvm-commits]

Oh wait, I was thinking that "*" matches _one_ or more characters. I
checked glob(7) and found that Sean is correct. So it is likely that our
implementation has a bug. I'll take a look at it and fix it.

On Thu, Sep 8, 2016 at 12:28 PM, Rafael Espíndola via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On 8 September 2016 at 15:04, Sean Silva <chisophugis at gmail.com> wrote:
> > The glob `*` can match zero, one, or many characters. Can you make sure
> that
> > the test covers those cases?
> >
> > Currently this test only verifies that it matches a single character, and
> > the test would pass if we treated `foo*` as `foo?`.
>
> True, but the patch used the existing matching infrastructure that is
> tested elsewhere. Do you thing expanding the test would add much
> value?
>
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160908/cf30c590/attachment.html>