[lld] r280947 - Handle globs in global symbol names.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 12:28:54 PDT 2016


On 8 September 2016 at 15:04, Sean Silva <chisophugis at gmail.com> wrote:
> The glob `*` can match zero, one, or many characters. Can you make sure that
> the test covers those cases?
>
> Currently this test only verifies that it matches a single character, and
> the test would pass if we treated `foo*` as `foo?`.

True, but the patch used the existing matching infrastructure that is
tested elsewhere. Do you thing expanding the test would add much
value?

Cheers,
Rafael


More information about the llvm-commits mailing list