[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Vitaly Buka via llvm-commits]

vitalybuka added a comment.

I like small patches, but they should be meaningful on it's own and incrementally improve code quality. 
Here we have patch with "unused" type which is safe be remove by anyone in the next patch.

It would be nice to have smallest possible patch but which has code which explain things like this:

1. Why we need NewAddressDescriptionBase. How this is different from ErrorDescription which is just fine without Base?
2. Why we need shouldLockThreadRegistry?
3. Why not to incrementally change AddressDescription?


================
Comment at: lib/asan/asan_descriptions.h:233
@@ +232,3 @@
+
+    if (shouldLockThreadRegistry) asanThreadRegistry().Lock();
+    if (GetStackAddressInformation(addr, &stack)) {
----------------
ThreadRegistryLock


https://reviews.llvm.org/D24131