[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.
Filipe Cabecinhas via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 6 14:32:09 PDT 2016
I chose to split the patch because then we get two smaller (and much
easier to review) patches instead of a big one doing two things at
once.
I can join them if you'd prefer.
Thank you,
Filipe
On Tue, Sep 6, 2016 at 7:58 PM, Vitaly Buka via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> vitalybuka requested changes to this revision.
> This revision now requires changes to proceed.
>
> ================
> Comment at: lib/asan/asan_descriptions.h:185
> @@ +184,3 @@
> + };
> + uptr Address() {
> + switch (kind) {
> ----------------
> Why not to replace existing ErrorDescription with this one n the same Patch so you don't need to introduce New* names
>
>
> https://reviews.llvm.org/D24131
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list