[llvm] r279952 - [Orc] Simplify LogicalDylib and move it back inside CompileOnDemandLayer. Also

[Renato Golin via llvm-commits]

On 29 August 2016 at 01:54, Lang Hames via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: lhames
> Date: Sun Aug 28 19:54:29 2016
> New Revision: 279952
>
> URL: http://llvm.org/viewvc/llvm-project?rev=279952&view=rev
> Log:
> [Orc] Simplify LogicalDylib and move it back inside CompileOnDemandLayer. Also
> switch to using one indirect stub manager per logical dylib rather than one per
> input module.

Hi Lang,

I'm really not sure, but I think this commit may be responsible for
many failures on our buildbots:

http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/7685/steps/build%20stage%202/logs/stdio

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3023/steps/build%20stage%201/logs/stdio

http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/4014/steps/build%20stage%201/logs/stdio

With the error:

FAILED: : && /usr/lib/ccache/c++   -mcpu=cortex-a15 -mthumb -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter
-Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic
-Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor
-Wno-comment -std=c++11 -ffunction-sections -fdata-sections -O3
-Wl,-allow-shlib-undefined   -Wl,--export-dynamic  -Wl,-O3
-Wl,--gc-sections tools/lli/CMakeFiles/lli.dir/lli.cpp.o
tools/lli/CMakeFiles/lli.dir/OrcLazyJIT.cpp.o  -o bin/lli
lib/libLLVMCodeGen.a lib/libLLVMCore.a lib/libLLVMExecutionEngine.a
lib/libLLVMIRReader.a lib/libLLVMInstrumentation.a
lib/libLLVMInterpreter.a lib/libLLVMMC.a lib/libLLVMMCJIT.a
lib/libLLVMObject.a lib/libLLVMOrcJIT.a lib/libLLVMRuntimeDyld.a
lib/libLLVMSelectionDAG.a lib/libLLVMSupport.a lib/libLLVMTarget.a
lib/libLLVMTransformUtils.a lib/libLLVMARMCodeGen.a
lib/libLLVMARMAsmPrinter.a lib/libLLVMARMAsmParser.a
lib/libLLVMARMDesc.a lib/libLLVMARMInfo.a lib/libLLVMARMDisassembler.a
-lpthread lib/libLLVMAsmParser.a lib/libLLVMExecutionEngine.a
lib/libLLVMRuntimeDyld.a lib/libLLVMObject.a lib/libLLVMSelectionDAG.a
lib/libLLVMAsmPrinter.a lib/libLLVMCodeGen.a
lib/libLLVMInstrumentation.a lib/libLLVMBitReader.a
lib/libLLVMBitWriter.a lib/libLLVMScalarOpts.a
lib/libLLVMInstCombine.a lib/libLLVMTarget.a
lib/libLLVMTransformUtils.a lib/libLLVMAnalysis.a
lib/libLLVMProfileData.a lib/libLLVMCore.a
lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a
lib/libLLVMMCParser.a lib/libLLVMARMDesc.a lib/libLLVMARMAsmPrinter.a
lib/libLLVMARMInfo.a lib/libLLVMMCDisassembler.a lib/libLLVMMC.a
lib/libLLVMSupport.a -lrt -ldl -ltinfo -lpthread -lz -lm
-Wl,-rpath,"\$ORIGIN/../lib" && :
tools/lli/CMakeFiles/lli.dir/OrcLazyJIT.cpp.o: In function `void
llvm::orc::CompileOnDemandLayer<llvm::orc::IRTransformLayer<llvm::orc::IRCompileLayer<llvm::orc::ObjectLinkingLayer<llvm::orc::DoNothingOnNotifyLoaded>
>, std::function<std::unique_ptr<llvm::Module,
std::default_delete<llvm::Module> > (std::unique_ptr<llvm::Module,
std::default_delete<llvm::Module> >)> >,
llvm::orc::JITCompileCallbackManager,
llvm::orc::IndirectStubsManager>::addLogicalModule<std::unique_ptr<llvm::Module,
std::default_delete<llvm::Module> >
>(llvm::orc::CompileOnDemandLayer<llvm::orc::IRTransformLayer<llvm::orc::IRCompileLayer<llvm::orc::ObjectLinkingLayer<llvm::orc::DoNothingOnNotifyLoaded>
>, std::function<std::unique_ptr<llvm::Module,
std::default_delete<llvm::Module> > (std::unique_ptr<llvm::Module,
std::default_delete<llvm::Module> >)> >,
llvm::orc::JITCompileCallbackManager,
llvm::orc::IndirectStubsManager>::LogicalDylib&,
std::unique_ptr<llvm::Module, std::default_delete<llvm::Module> >)':
OrcLazyJIT.cpp:(.text._ZN4llvm3orc20CompileOnDemandLayerINS0_16IRTransformLayerINS0_14IRCompileLayerINS0_18ObjectLinkingLayerINS0_23DoNothingOnNotifyLoadedEEEEESt8functionIFSt10unique_ptrINS_6ModuleESt14default_deleteISA_EESD_EEEENS0_25JITCompileCallbackManagerENS0_20IndirectStubsManagerEE16addLogicalModuleISD_EEvRNSJ_12LogicalDylibET_[_ZN4llvm3orc20CompileOnDemandLayerINS0_16IRTransformLayerINS0_14IRCompileLayerINS0_18ObjectLinkingLayerINS0_23DoNothingOnNotifyLoadedEEEEESt8functionIFSt10unique_ptrINS_6ModuleESt14default_deleteISA_EESD_EEEENS0_25JITCompileCallbackManagerENS0_20IndirectStubsManagerEE16addLogicalModuleISD_EEvRNSJ_12LogicalDylibET_]+0x45a):
undefined reference to
`llvm::orc::cloneModuleFlagsMetadata(llvm::Module&, llvm::Module
const&, llvm::ValueMap<llvm::Value const*, llvm::WeakVH,
llvm::ValueMapConfig<llvm::Value const*, llvm::sys::SmartMutex<false>
> >&)'

Unfortunately, our bots didn't detect because of a change in the
builder which made all bots not report any errors.

If you can't fix it quickly, please revert and we'll investigate that
later, as right now, we're dealing with a large number of concurrent
failures and we won't have time to investigate further.

Sorry.

--renato