[PATCH] D23766: DebugInfo: use strongly typed enum for debug info flags

[Victor Leschuk via llvm-commits]

If you try to store value which is larger than FlagLargest it will 
trigger assert() in BitmapEnum. So these tests look  invalid for me now.
On 09/02/2016 06:36 PM, David Blaikie wrote:
> Are those tests actually invalid now? You can still stuff non-flag 
> values into the flag with a static cast, so perhaps we should keep the 
> test around in that form?
>
> On Thu, Sep 1, 2016 at 11:51 PM Victor <vleschuk at gmail.com 
> <mailto:vleschuk at gmail.com>> wrote:
>
>     vleschuk updated this revision to Diff 70135.
>     vleschuk added a comment.
>
>     Removed few deprecated tests which don't make sense with new type
>     for flags.
>
>
>     https://reviews.llvm.org/D23766
>
>     Files:
>       include/llvm/IR/DIBuilder.h
>       include/llvm/IR/DebugInfoFlags.def
>       include/llvm/IR/DebugInfoMetadata.h
>       lib/AsmParser/LLParser.cpp
>       lib/Bitcode/Reader/BitcodeReader.cpp
>       lib/IR/AsmWriter.cpp
>       lib/IR/DIBuilder.cpp
>       lib/IR/DebugInfoMetadata.cpp
>       unittests/IR/DebugInfoTest.cpp
>       unittests/IR/DebugTypeODRUniquingTest.cpp
>       unittests/IR/IRBuilderTest.cpp
>       unittests/IR/MetadataTest.cpp
>       unittests/Transforms/Utils/Cloning.cpp
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160902/37c4d4c8/attachment.html>