<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
If you try to store value which is larger than FlagLargest it will
trigger assert() in BitmapEnum. So these tests look invalid for me
now.<br>
<div class="moz-cite-prefix">On 09/02/2016 06:36 PM, David Blaikie
wrote:<br>
</div>
<blockquote
cite="mid:CAENS6EtP_sLg7S2TiewiYowzdgsdo0J5NUZ-V1k-ur5-mdJYNw@mail.gmail.com"
type="cite">
<div dir="ltr">Are those tests actually invalid now? You can still
stuff non-flag values into the flag with a static cast, so
perhaps we should keep the test around in that form?</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Sep 1, 2016 at 11:51 PM Victor <<a
moz-do-not-send="true" href="mailto:vleschuk@gmail.com"><a class="moz-txt-link-abbreviated" href="mailto:vleschuk@gmail.com">vleschuk@gmail.com</a></a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">vleschuk
updated this revision to Diff 70135.<br>
vleschuk added a comment.<br>
<br>
Removed few deprecated tests which don't make sense with new
type for flags.<br>
<br>
<br>
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D23766" rel="noreferrer"
target="_blank">https://reviews.llvm.org/D23766</a><br>
<br>
Files:<br>
include/llvm/IR/DIBuilder.h<br>
include/llvm/IR/DebugInfoFlags.def<br>
include/llvm/IR/DebugInfoMetadata.h<br>
lib/AsmParser/LLParser.cpp<br>
lib/Bitcode/Reader/BitcodeReader.cpp<br>
lib/IR/AsmWriter.cpp<br>
lib/IR/DIBuilder.cpp<br>
lib/IR/DebugInfoMetadata.cpp<br>
unittests/IR/DebugInfoTest.cpp<br>
unittests/IR/DebugTypeODRUniquingTest.cpp<br>
unittests/IR/IRBuilderTest.cpp<br>
unittests/IR/MetadataTest.cpp<br>
unittests/Transforms/Utils/Cloning.cpp<br>
<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>