[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 23:14:03 PDT 2016


dberris added inline comments.

================
Comment at: lib/Target/X86/X86AsmPrinter.h:74-94
@@ -73,23 +73,2 @@
 
-  // This describes the kind of sled we're storing in the XRay table.
-  enum class SledKind : uint8_t {
-    FUNCTION_ENTER = 0,
-    FUNCTION_EXIT = 1,
-    TAIL_CALL = 2,
-  };
-
-  // The table will contain these structs that point to the sled, the function
-  // containing the sled, and what kind of sled (and whether they should always
-  // be instrumented).
-  struct XRayFunctionEntry {
-    const MCSymbol *Sled;
-    const MCSymbol *Function;
-    SledKind Kind;
-    bool AlwaysInstrument;
-    const class Function *Fn;
-  };
-
-  // All the sleds to be emitted.
-  std::vector<XRayFunctionEntry> Sleds;
-
   // All instructions emitted by the X86AsmPrinter should use this helper
----------------
Definitely a description in the diff.


https://reviews.llvm.org/D23931





More information about the llvm-commits mailing list