[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D23931#531728, @rSerge wrote:

> > Do you mean not supported in the Sled code, or inserting ARM Sled code into Thumb functions?
>
>
> Neither is supported. I estimated that Thumb support requires substantial additional effort.


My gut feeling is that this should mostly work already, since you're using BLX instructions.

But I agree, let's not get ahead of ourselves.

Limit support for ARMv7A, non-Windows (which forces Thumb2). Something like:

  if (!SubTarget->hasV7Ops() || SubTarget->isWindows())
    return Forgerabarit.

cheers,
--renato


https://reviews.llvm.org/D23931