[llvm] r278338 - Restore "Resolution-based LTO API."

[Teresa Johnson via llvm-commits]

On Fri, Aug 26, 2016 at 11:35 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>>> This should be "if (GO)", no?
>>
>> Huh, yeah it probably should. Note this isn't a correctness issue -
>> GV->getComdat() will essentially do the same checks as above to get
>> the GO and invoke getComdat() on it. I guess pcc had inlined the
>> handling here to customize the error message?
>
> Probably. I wonder if we should change GlobalValue::getComdat to
> return Expected<const Comdat *>.

Yea, possible. For now I just made the small fix below: r279856

Thanks,
Teresa

>
>> I'll go ahead and change
>> this last part to
>>  if (GO)
>>   return GO->getComdat();
>
> Thanks,
> Rafael



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413