[llvm] r278338 - Restore "Resolution-based LTO API."

[Rafael Espíndola via llvm-commits]

>> This should be "if (GO)", no?
>
> Huh, yeah it probably should. Note this isn't a correctness issue -
> GV->getComdat() will essentially do the same checks as above to get
> the GO and invoke getComdat() on it. I guess pcc had inlined the
> handling here to customize the error message?

Probably. I wonder if we should change GlobalValue::getComdat to
return Expected<const Comdat *>.

> I'll go ahead and change
> this last part to
>  if (GO)
>   return GO->getComdat();

Thanks,
Rafael