jordy.potman.lists added inline comments. ================ Comment at: lib/Target/RISCV/RISCVInstrFormats.td:143 @@ +142,3 @@ +{ + bits<21> imm20; + bits<5> rd; ---------------- Shouldn't this now be ``` bits<20> imm20; ``` ? https://reviews.llvm.org/D23561