[PATCH] D23916: [Polly] Check validity of new access relations. NFC.

[Roman via llvm-commits]

gareevroman added a comment.

Hi Michael,

thank you for the patch. It looks good also to me.


================
Comment at: include/polly/Support/ScopHelper.h:451
@@ -436,1 +450,3 @@
+bool isl_space_is_compatible(__isl_keep isl_space *Space1,
+                             __isl_keep isl_space *Space2);
 } // namespace polly
----------------
grosser wrote:
> This really belongs into isl. We can probably add this here for now, as having a local copy has minimal cost, but we should probably contribute a corresponding patch upstream.
We should possibly rename it to, for example, SpaceIsCompatible, if we want to declare it here.


https://reviews.llvm.org/D23916