[PATCH] D23916: [Polly] Check validity of new access relations. NFC.

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael.

these changes look good to me, but we should probably coordinate with Roman before committing them. Thanks for already reaching out to him.

@Roman: As you have been working in this area, could you please also review this change?

Best,
Tobias


================
Comment at: include/polly/Support/ScopHelper.h:451
@@ -436,1 +450,3 @@
+bool isl_space_is_compatible(__isl_keep isl_space *Space1,
+                             __isl_keep isl_space *Space2);
 } // namespace polly
----------------
This really belongs into isl. We can probably add this here for now, as having a local copy has minimal cost, but we should probably contribute a corresponding patch upstream.


https://reviews.llvm.org/D23916