[PATCH] D23833: [Polly] Introduce unittests.

[Michael Kruse via llvm-commits]

2016-08-24 17:49 GMT+02:00 Tobias Grosser via llvm-commits
<llvm-commits at lists.llvm.org>:
>> >> Meinersbur marked 3 inline comments as done.
>> >> Meinersbur added a comment.
>> >>
>> >> Out-of-tree unit tests are not easy as it requires gtest from the LLVM
>> >> source tree. Polly up to now only requires the LLVM_INSTALL_ROOT.
>> >> llvm-config can be queried for the source dir, but then we need to
>> >> compile gtest ourselves.
>> >>
>> >> Clang has a different approach: It requires the source tree and broadly
>> >> imports all cmake files such that it can use the LLVM functions to build
>> >> the files.
>> >
>> > We can possibly just skip them in out-of-tree builds. This is clearly
>> > not the most common configuration.
>>
>> All the buildbots do.
>
> All performance buildbots, but not the one that runs at ENS and tests
> 'make check'. As such, our buildbots will cover the unit-tests even if
> we exclude the
> out-of-tree builds. We can probably remove the support for out-of-tree
> builds at some point, but for this the performance test buildbots need
> to be updated. As this does not seem urgent, I would leave them as they
> are for now.

Sorry for my ignorance. The only build configuration I could find that
does in-tree builds is "polly-amd64-linux".
http://lab.llvm.org:8011/builders/polly-amd64-linux/builds/45219/steps/cmake-configure/logs/stdio

The one at ENS has an Intel processor and doesn't do anything atm.
When is it triggered?

All others use LLVM_INSTALL_ROOT:
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/19267/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-parallel-fast/builds/23096/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-unprofitable/builds/10139/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly/builds/7186/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-before-vectorizer/builds/1360/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-before-vectorizer-unprofitable/builds/6046/steps/cmake-configure/logs/stdio
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-before-vectorizer-detect-only/builds/1344/steps/cmake-configure/logs/stdio

It may not matter anymore; my goal was to have the buildbots run the
unittests as well and works now.

Michael