[PATCH] D23833: [Polly] Introduce unittests.

[Tobias Grosser via llvm-commits]

> >> Meinersbur marked 3 inline comments as done.
> >> Meinersbur added a comment.
> >>
> >> Out-of-tree unit tests are not easy as it requires gtest from the LLVM
> >> source tree. Polly up to now only requires the LLVM_INSTALL_ROOT.
> >> llvm-config can be queried for the source dir, but then we need to
> >> compile gtest ourselves.
> >>
> >> Clang has a different approach: It requires the source tree and broadly
> >> imports all cmake files such that it can use the LLVM functions to build
> >> the files.
> >
> > We can possibly just skip them in out-of-tree builds. This is clearly
> > not the most common configuration.
> 
> All the buildbots do.

All performance buildbots, but not the one that runs at ENS and tests
'make check'. As such, our buildbots will cover the unit-tests even if
we exclude the
out-of-tree builds. We can probably remove the support for out-of-tree
builds at some point, but for this the performance test buildbots need
to be updated. As this does not seem urgent, I would leave them as they
are for now.

> To clarify: With out-of-tree builds I mean running cmake in the Polly
> directory and referring to LLVM using LLVM_INSTALL_ROOT.

This is what I understood.

Best,
Tobias