[PATCH] D23839: [ELF] - Fix for: bug 29115 - linkerscript does not support non-wildcard filename spec.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:949
@@ -950,3 +948,3 @@
     else
-      setError("unknown command " + Tok);
+      Cmd->Commands.emplace_back(readInputSectionDescription(Tok));
   }
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > So we no longer print out "unknown command" error, don't we? I think we want that error.
> > I am not sure it is possible to recognize unknown command here. It can be just a name of file. If not then readInputSectionDescription() will report something.
> A filename must be followed by '(', no?
Yes and that is a problem. Because
filename.a [ ... )
does not mean that filename.a is a unknown command, but just means that input section description is incorrect.
So there is no good solution here I think. Though I can do such check here If you think it is better.


https://reviews.llvm.org/D23839