[PATCH] D23839: [ELF] - Fix for: bug 29115 - linkerscript does not support non-wildcard filename spec.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 01:23:22 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:949
@@ -950,3 +948,3 @@
     else
-      setError("unknown command " + Tok);
+      Cmd->Commands.emplace_back(readInputSectionDescription(Tok));
   }
----------------
grimar wrote:
> ruiu wrote:
> > So we no longer print out "unknown command" error, don't we? I think we want that error.
> I am not sure it is possible to recognize unknown command here. It can be just a name of file. If not then readInputSectionDescription() will report something.
A filename must be followed by '(', no?


https://reviews.llvm.org/D23839





More information about the llvm-commits mailing list