[llvm] r279599 - Increase the size of the sigaltstack used by LLVM signal handlers. 8KB is not

[Hahnfeld, Jonas via llvm-commits]

Hey,

what kind of review is this? The developer policy states:
"If someone sends you a patch privately, encourage them to submit it to the 
appropriate list first."

I btw posted an exact same patch more than 2 months ago and also put you as 
reviewer: https://reviews.llvm.org/D21222
The patch was confirmed to work by another user, but hasn't received any other 
comments although being a one-liner.
(I have now abandoned it as (obviously) this committed change works for me as 
well.)

Jonas

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Richard Smith via llvm-commits
> Sent: Wednesday, August 24, 2016 2:55 AM
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r279599 - Increase the size of the sigaltstack used by LLVM
> signal handlers. 8KB is not
>
> Author: rsmith
> Date: Tue Aug 23 19:54:49 2016
> New Revision: 279599
>
> URL: http://llvm.org/viewvc/llvm-project?rev=279599&view=rev
> Log:
> Increase the size of the sigaltstack used by LLVM signal handlers. 8KB is 
> not
> sufficient in some cases; increase to 64KB, which should be enough for
> anyone :)
>
> Patch by github.com/bryant!
>
> Modified:
>     llvm/trunk/lib/Support/Unix/Signals.inc
>
> Modified: llvm/trunk/lib/Support/Unix/Signals.inc
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/Support/Unix/Signals.inc?rev=279599&r1=279598&r2=
> 279599&view=diff
> ==========================================================
> ====================
> --- llvm/trunk/lib/Support/Unix/Signals.inc (original)
> +++ llvm/trunk/lib/Support/Unix/Signals.inc Tue Aug 23 19:54:49 2016
> @@ -127,7 +127,7 @@ static void RegisterHandler(int Signal)  static stack_t
> OldAltStack;
>
>  static void CreateSigAltStack() {
> -  const size_t AltStackSize = MINSIGSTKSZ + 8192;
> +  const size_t AltStackSize = MINSIGSTKSZ + 64 * 1024;
>
>    // If we're executing on the alternate stack, or we already have an 
> alternate
>    // signal stack that we're happy with, there's nothing for us to do. 
> Don't
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160825/59f8ab62/attachment.bin>