[llvm] r279599 - Increase the size of the sigaltstack used by LLVM signal handlers. 8KB is not

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 13:12:39 PDT 2016


This patch introduced memory leaks
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15762/steps/check-llvm%20asan/logs/stdio

On Tue, Aug 23, 2016 at 6:02 PM Richard Smith via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rsmith
> Date: Tue Aug 23 19:54:49 2016
> New Revision: 279599
>
> URL: http://llvm.org/viewvc/llvm-project?rev=279599&view=rev
> Log:
> Increase the size of the sigaltstack used by LLVM signal handlers. 8KB is
> not
> sufficient in some cases; increase to 64KB, which should be enough for
> anyone :)
>
> Patch by github.com/bryant!
>
> Modified:
>     llvm/trunk/lib/Support/Unix/Signals.inc
>
> Modified: llvm/trunk/lib/Support/Unix/Signals.inc
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Signals.inc?rev=279599&r1=279598&r2=279599&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Support/Unix/Signals.inc (original)
> +++ llvm/trunk/lib/Support/Unix/Signals.inc Tue Aug 23 19:54:49 2016
> @@ -127,7 +127,7 @@ static void RegisterHandler(int Signal)
>  static stack_t OldAltStack;
>
>  static void CreateSigAltStack() {
> -  const size_t AltStackSize = MINSIGSTKSZ + 8192;
> +  const size_t AltStackSize = MINSIGSTKSZ + 64 * 1024;
>
>    // If we're executing on the alternate stack, or we already have an
> alternate
>    // signal stack that we're happy with, there's nothing for us to do.
> Don't
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160824/ca549c9c/attachment.html>


More information about the llvm-commits mailing list