[llvm] r279493 - [MemorySSA] Remove unused field. NFC.
George Burgess IV via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 22 16:40:01 PDT 2016
Author: gbiv
Date: Mon Aug 22 18:40:01 2016
New Revision: 279493
URL: http://llvm.org/viewvc/llvm-project?rev=279493&view=rev
Log:
[MemorySSA] Remove unused field. NFC.
Given that we're not currently using blocker info, and whether or not we
will end up using it it is unclear, don't waste 8 (or 4) bytes of memory
per path node.
Modified:
llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp
Modified: llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp?rev=279493&r1=279492&r2=279493&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/MemorySSA.cpp Mon Aug 22 18:40:01 2016
@@ -490,9 +490,6 @@ class ClobberWalker {
// First. Also note that First and Last are inclusive.
MemoryAccess *First;
MemoryAccess *Last;
- // N.B. Blocker is currently basically unused. The goal is to use it to make
- // cache invalidation better, but we're not there yet.
- MemoryAccess *Blocker;
Optional<ListIndex> Previous;
DefPath(const MemoryLocation &Loc, MemoryAccess *First, MemoryAccess *Last,
@@ -834,8 +831,7 @@ class ClobberWalker {
// FIXME: This is broken, because the Blocker may be reported to be
// liveOnEntry, and we'll happily wait for that to disappear (read: never)
- // For the moment, this is fine, since we do basically nothing with
- // blocker info.
+ // For the moment, this is fine, since we do nothing with blocker info.
if (Optional<TerminatedPath> Blocker = getBlockingAccess(
Target, PausedSearches, NewPaused, TerminatedPaths)) {
// Cache our work on the blocking node, since we know that's correct.
@@ -850,7 +846,6 @@ class ClobberWalker {
DefPath &CurNode = *Iter;
assert(CurNode.Last == Current);
- CurNode.Blocker = Blocker->Clobber;
// Two things:
// A. We can't reliably cache all of NewPaused back. Consider a case
More information about the llvm-commits
mailing list