[PATCH] D23701: [PM] Rework the new PM support for building the ModuleSummaryIndex to directly produce the index as the value type result.

[Chandler Carruth via llvm-commits]

chandlerc added inline comments.

================
Comment at: include/llvm/Analysis/ModuleSummaryAnalysis.h:45
@@ -78,3 +44,3 @@
 
-  const ModuleSummaryIndex &run(Module &M, ModuleAnalysisManager &AM);
+  ModuleSummaryIndex run(Module &M, ModuleAnalysisManager &AM);
 };
----------------
mehdi_amini wrote:
> You define a typedef for `Result` two lines above, why not using it here? 
> 
> I don't think it is used anywhere, if it is only used by the pass manager infrastructure, maybe add a comment above the typedef.
Happy to use the typedef if you prefer.

But the typedef is for the pass manager infrastructure. I can comment it, but it is a fairly pervasive pattern so not sure how much value that comment adds. Thoughts? Would you like a comment on all the Result typedefs?


https://reviews.llvm.org/D23701