[PATCH] D23701: [PM] Rework the new PM support for building the ModuleSummaryIndex to directly produce the index as the value type result.

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

LGTM.

I like functions better than classes when possible :)


================
Comment at: include/llvm/Analysis/ModuleSummaryAnalysis.h:45
@@ -78,3 +44,3 @@
 
-  const ModuleSummaryIndex &run(Module &M, ModuleAnalysisManager &AM);
+  ModuleSummaryIndex run(Module &M, ModuleAnalysisManager &AM);
 };
----------------
You define a typedef for `Result` two lines above, why not using it here? 

I don't think it is used anywhere, if it is only used by the pass manager infrastructure, maybe add a comment above the typedef.


https://reviews.llvm.org/D23701