[PATCH] D22949: Speed up Function::isIntrinsic() by adding a bit to GlobalValue. NFC

[Sean Silva via llvm-commits]

On Wed, Aug 17, 2016 at 4:48 PM, Justin Lebar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> jlebar added a comment.
>
> Justin Bogner wrote in an email to the list:
>
> > I'm a bit less comfortable with this change than I was with the other
>
> >  one - it's more of a straight performance hack this way, whereas the
>
> >  other way fit better in a future where target-specific intrinsics are
>
> >  more of a first class idea.
>
> >
>
> > I'll let others comment on whether or not this is worth it as a
>
> >  hopefully temporary thing for the performance gain in the short term.
>
>
> Anyone else want to chime in here?  To me it seems like a relatively
> simple change that gets us a substantial win,


Sorry if I missed it, but do you have perf measurements posted somewhere?

-- Sean Silva


> but I hear Justin B.'s position as well.
>
>
> https://reviews.llvm.org/D22949
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/c08f5b62/attachment.html>