[PATCH] D22949: Speed up Function::isIntrinsic() by adding a bit to GlobalValue. NFC

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 16:48:29 PDT 2016


jlebar added a comment.

Justin Bogner wrote in an email to the list:

> I'm a bit less comfortable with this change than I was with the other

>  one - it's more of a straight performance hack this way, whereas the

>  other way fit better in a future where target-specific intrinsics are

>  more of a first class idea.

> 

> I'll let others comment on whether or not this is worth it as a

>  hopefully temporary thing for the performance gain in the short term.


Anyone else want to chime in here?  To me it seems like a relatively simple change that gets us a substantial win, but I hear Justin B.'s position as well.


https://reviews.llvm.org/D22949





More information about the llvm-commits mailing list