[PATCH] D23598: [ELF] Linkerscript: support assignment outside SECTIONS
Petr Hosek via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 17 18:55:44 PDT 2016
phosek added inline comments.
================
Comment at: ELF/LinkerScript.h:70-72
@@ -69,2 +69,5 @@
bool Hidden = false;
+
+ // Whether the "." is available.
+ bool DotAvailable = true;
};
----------------
ruiu wrote:
> Let's remove this -- as I wrote in the previous comment, this is not an error we are detecting in other contexts, and it is okay to ignore them. I don't think it's a popular error, and it is "undefined behavior" (if there were the linker script language specification.)
I believe we still need some way to recognize whether the assignment is inside `SECTIONS` or not to avoid modifying `.` in case it's not when assigning addresses inside `assignAddress()`?
https://reviews.llvm.org/D23598
More information about the llvm-commits
mailing list