[PATCH] D23598: [ELF] Linkerscript: support assignment outside SECTIONS

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 18:47:11 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.h:70-72
@@ -69,2 +69,5 @@
   bool Hidden = false;
+
+  // Whether the "." is available.
+  bool DotAvailable = true;
 };
----------------
Let's remove this -- as I wrote in the previous comment, this is not an error we are detecting in other contexts, and it is okay to ignore them. I don't think it's a popular error, and it is "undefined behavior" (if there were the linker script language specification.)


https://reviews.llvm.org/D23598





More information about the llvm-commits mailing list