[PATCH] D22512: Added hash_stream class for producing hash codes from data streams.

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D22512#518736, @teemperor wrote:

> This intention of this patch wasn't to extend the proposed API in any way; the only reason why the hash_stream class landed here is because LLVM's CityHash implementation is in this file's ::detail:: namespace and implementing hash_stream somewhere else would mean depending on the implementation details in different source files. Sorry about the confusion.
>
> As the CityHash implementation isn't part of N3333: What about moving that implementation to it's own implementation header file and let Hashing.h and hash_stream use it? With that Hashing.h would only contain N3333 API and hash_stream could use the same backend in a clean way.


None of this actually addresses my comment though: "I'd like to understand the immediate motivation here..."

Shifting the interface we expand from one file to another doesn't really change much IMO.


https://reviews.llvm.org/D22512