[PATCH] D22512: Added hash_stream class for producing hash codes from data streams.

[Raphael Isemann via llvm-commits]

teemperor added a comment.

This intention of this patch wasn't to extend the proposed API in any way; the only reason why the hash_stream class landed here is because LLVM's CityHash implementation is in this file's ::detail:: namespace and implementing hash_stream somewhere else would mean depending on the implementation details in different source files. Sorry about the confusion.

As the CityHash implementation isn't part of N3333: What about moving that implementation to it's own implementation header file and let Hashing.h and hash_stream use it? With that Hashing.h would only contain N3333 API and hash_stream could use the same backend in a clean way.


https://reviews.llvm.org/D22512