[PATCH] D23601: [TII] add new target hook isAdd

[Krzysztof Parzyszek via llvm-commits]

kparzysz added inline comments.

================
Comment at: include/llvm/Target/TargetInstrInfo.h:1086
@@ -1085,1 +1085,3 @@
 
+  /// Returns true if the instruction is an add instruction
+  virtual bool isAdd(const MachineInstr &MI) const {
----------------
There should be some description about what is expected from an instruction for which this function returns "true".  Something like: one output operand (0), two input operands (1 and 2), either input can be an immediate/register/global symbol/etc.  Should the instruction be free from any side-effects (such as setting some flags), or it does not matter? And so on.


https://reviews.llvm.org/D23601