[PATCH] D23052: [Inliner] Add a flag to disable manual alloca merging in the Inliner.

[Chandler Carruth via llvm-commits]

Thanks for the review and all the careful testing!

I'm landing this and then we can do more experiments on just what the
impact of turning this off would be, both in -O2 and -O0 pipelines.

On Thu, Aug 11, 2016 at 8:38 AM Balaram Makam via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> bmakam added a comment.
>
> In https://reviews.llvm.org/D23052#509953, @bmakam wrote:
>
> > In https://reviews.llvm.org/D23052#509942, @mcrosier wrote:
> >
> > > In https://reviews.llvm.org/D23052#509930, @bmakam wrote:
> > >
> > > > In https://reviews.llvm.org/D23052#508976, @mcrosier wrote:
> > > >
> > > > > @bmakam: Would you mind downloading and testing this patch?
> Please do full correctness and SPEC200X performance (our head-to-head
> methodology with train input would be fine).
> > > >
> > > >
> > > > Tested on Kryo. Only these SPEC200X benchmarks had non-noise
> performance gains(runtime) with this change:
> > > >  | spec2006/soplex:train    | [-2.347%, +3.157%]
> > > >  |spec2006/sphinx3:train   | [+0.469%, +2.124%]
> > > >  |spec2006/xalancbmk:train|[+6.566%, +8.743%] |
> > > >  There were no regressions.
> > >
> > >
> > > Thanks, Balaram.  No correctness issues, correct?
> >
> >
> > Oh I forgot running full correctness. There were no correctness issues
> in SPEC200X benchmarks. I will run full correctness tests.
>
>
> Just finished running full correctness tests. There were no correctness
> issues found in my tests.
> Thanks,
> Balaram
>
>
> https://reviews.llvm.org/D23052
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/458f31e0/attachment.html>