<div dir="ltr">Thanks for the review and all the careful testing!<div><br></div><div>I'm landing this and then we can do more experiments on just what the impact of turning this off would be, both in -O2 and -O0 pipelines.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 11, 2016 at 8:38 AM Balaram Makam via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">bmakam added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D23052#509953" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23052#509953</a>, @bmakam wrote:<br>
<br>
> In <a href="https://reviews.llvm.org/D23052#509942" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23052#509942</a>, @mcrosier wrote:<br>
><br>
> > In <a href="https://reviews.llvm.org/D23052#509930" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23052#509930</a>, @bmakam wrote:<br>
> ><br>
> > > In <a href="https://reviews.llvm.org/D23052#508976" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23052#508976</a>, @mcrosier wrote:<br>
> > ><br>
> > > > @bmakam: Would you mind downloading and testing this patch?  Please do full correctness and SPEC200X performance (our head-to-head methodology with train input would be fine).<br>
> > ><br>
> > ><br>
> > > Tested on Kryo. Only these SPEC200X benchmarks had non-noise performance gains(runtime) with this change:<br>
> > >  | spec2006/soplex:train    | [-2.347%, +3.157%]<br>
> > >  |spec2006/sphinx3:train   | [+0.469%, +2.124%]<br>
> > >  |spec2006/xalancbmk:train|[+6.566%, +8.743%] |<br>
> > >  There were no regressions.<br>
> ><br>
> ><br>
> > Thanks, Balaram.  No correctness issues, correct?<br>
><br>
><br>
> Oh I forgot running full correctness. There were no correctness issues in SPEC200X benchmarks. I will run full correctness tests.<br>
<br>
<br>
Just finished running full correctness tests. There were no correctness issues found in my tests.<br>
Thanks,<br>
Balaram<br>
<br>
<br>
<a href="https://reviews.llvm.org/D23052" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23052</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>