[llvm] r278560 - [AArch64] Registering default MCInstrAnalysis

Mon Aug 15 15:39:07 PDT 2016

Sorry for the breakage. I have split the test in to with appropriate
REQUIRES not to break bots without AArch64 compiled in.

On Fri, Aug 12, 2016 at 4:30 PM Sanjoy Das <sanjoy at playingwithpointers.com>
wrote:

> This is failing on linux-x86_64 for me too -- perhaps this is missing a
> REQUIRES line?
>
> [697/697] Linking CXX executable bin/opt
> [126/126] Running the LLVM regression tests
> FAIL: LLVM :: tools/sancov/print_coverage_pcs.test (17650 of 17651)
> ******************** TEST 'LLVM ::
> tools/sancov/print_coverage_pcs.test' FAILED ********************
> Script:
> --
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov
> -print-coverage-pcs
> /local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-linux_x86_64 |
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test
> --check-prefix=LINUX
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/llvm-objdump -d
> /local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-windows_x86_64 |
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test
> --check-prefix=DISAS_WIN
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov
> -print-coverage-pcs
> /local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-windows_x86_64 |
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test
> --check-prefix=WINDOWS
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov
> -print-coverage-pcs
> /local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-darwin_x86_64 |
> /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test
> --check-prefix=DARWIN
> not /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov
> -print-coverage-pcs
> /local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-linux_android_aarch64
> 2>&1 | /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test
> --check-prefix=AARCH64
> --
> Exit Code: 1
>
> Command Output (stderr):
> --
> /local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test:62:10:
> error: expected string not found in input
> AARCH64: Error: __sanitizer_cov* functions not found
>          ^
> <stdin>:1:1: note: scanning from here
> Error: No available targets are compatible with this triple.
> ^
>
> --
>
> ********************
> Testing Time: 89.35s
> ********************
> Failing Tests (1):
>     LLVM :: tools/sancov/print_coverage_pcs.test
>
>   Expected Passes    : 10703
>   Expected Failures  : 32
>   Unsupported Tests  : 6915
>   Unexpected Failures: 1
> FAILED: cd /local/sanjoy/llvm.git/build/debug+asserts-x86/test &&
> /home/buildmaster/sw/python/2.7.3/linux/x86_64/bin/python2.7
> /local/sanjoy/llvm.git/utils/lit/lit.py -sv --param
>
> llvm_site_config=/local/sanjoy/llvm.git/build/debug+asserts-x86/test/lit.site.cfg
> --param
> llvm_unit_site_config=/local/sanjoy/llvm.git/build/debug+asserts-x86/test/Unit/lit.site.cfg
> /local/sanjoy/llvm.git/build/debug+asserts-x86/test
> ninja: build stopped: subcommand failed.
>
> On Fri, Aug 12, 2016 at 3:43 PM, Yung, Douglas via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Hi Mike,
> >
> > This change is causing a failure on the PS4 bot with an error "No
> available targets are compatible with this triple." I suspect because the
> PS4 target only builds the x86 target, and then fails when trying to run
> this test and cannot find AArch64. Can you take a look into this issue?
> >
> > Douglas Yung
> >
> >> -----Original Message-----
> >> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
> >> Behalf Of Mike Aizatsky via llvm-commits
> >> Sent: Friday, August 12, 2016 13:28
> >> To: llvm-commits at lists.llvm.org
> >> Subject: [llvm] r278560 - [AArch64] Registering default MCInstrAnalysis
> >>
> >> Author: aizatsky
> >> Date: Fri Aug 12 15:28:05 2016
> >> New Revision: 278560
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=278560&view=rev
> >> Log:
> >> [AArch64] Registering default MCInstrAnalysis
> >>
> >> Even in this form it is useful: it can detect branch instructions.
> >>
> >> https://github.com/google/sanitizers/issues/706
> >>
> >> Subscribers: aemerson, rengolin
> >>
> >> Differential Revision: https://reviews.llvm.org/D23426
> >>
> >> Added:
> >>     llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64
> >> Modified:
> >>     llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
> >>     llvm/trunk/test/tools/sancov/print_coverage_pcs.test
> >>
> >> Modified:
> >> llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
> >> URL: http://llvm.org/viewvc/llvm-
> >> project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.
> >> cpp?rev=278560&r1=278559&r2=278560&view=diff
> >> =======================================================================
> >> =======
> >> --- llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
> >> (original)
> >> +++ llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
> >> +++ Fri Aug 12 15:28:05 2016
> >> @@ -15,6 +15,7 @@
> >>  #include "AArch64ELFStreamer.h"
> >>  #include "AArch64MCAsmInfo.h"
> >>  #include "InstPrinter/AArch64InstPrinter.h"
> >> +#include "llvm/MC/MCInstrAnalysis.h"
> >>  #include "llvm/MC/MCInstrInfo.h"
> >>  #include "llvm/MC/MCRegisterInfo.h"
> >>  #include "llvm/MC/MCStreamer.h"
> >> @@ -116,6 +117,10 @@ static MCStreamer *createMachOStreamer(M
> >>                               /*LabelSections*/ true);  }
> >>
> >> +static MCInstrAnalysis *createAArch64InstrAnalysis(const MCInstrInfo
> >> +*Info) {
> >> +  return new MCInstrAnalysis(Info);
> >> +}
> >> +
> >>  // Force static initialization.
> >>  extern "C" void LLVMInitializeAArch64TargetMC() {
> >>    for (Target *T :
> >> @@ -135,6 +140,9 @@ extern "C" void LLVMInitializeAArch64Tar
> >>      // Register the MC subtarget info.
> >>      TargetRegistry::RegisterMCSubtargetInfo(*T,
> >> createAArch64MCSubtargetInfo);
> >>
> >> +    // Register the MC instruction analyzer.
> >> +    TargetRegistry::RegisterMCInstrAnalysis(*T,
> >> + createAArch64InstrAnalysis);
> >> +
> >>      // Register the MC Code Emitter
> >>      TargetRegistry::RegisterMCCodeEmitter(*T,
> >> createAArch64MCCodeEmitter);
> >>
> >>
> >> Added: llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64
> >> URL: http://llvm.org/viewvc/llvm-
> >> project/llvm/trunk/test/tools/sancov/Inputs/test-
> >> linux_android_aarch64?rev=278560&view=auto
> >> =======================================================================
> >> =======
> >> Binary files llvm/trunk/test/tools/sancov/Inputs/test-
> >> linux_android_aarch64 (added) and
> >> llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64 Fri Aug
> >> 12 15:28:05 2016 differ
> >>
> >> Modified: llvm/trunk/test/tools/sancov/print_coverage_pcs.test
> >> URL: http://llvm.org/viewvc/llvm-
> >> project/llvm/trunk/test/tools/sancov/print_coverage_pcs.test?rev=278560
> >> &r1=278559&r2=278560&view=diff
> >> =======================================================================
> >> =======
> >> --- llvm/trunk/test/tools/sancov/print_coverage_pcs.test (original)
> >> +++ llvm/trunk/test/tools/sancov/print_coverage_pcs.test Fri Aug 12
> >> +++ 15:28:05 2016
> >> @@ -3,6 +3,7 @@ RUN: sancov -print-coverage-pcs %p/Input
> >>  RUN: llvm-objdump -d %p/Inputs/test-windows_x86_64 | FileCheck %s --
> >> check-prefix=DISAS_WIN
> >>  RUN: sancov -print-coverage-pcs %p/Inputs/test-windows_x86_64 |
> >> FileCheck %s --check-prefix=WINDOWS
> >>  RUN: sancov -print-coverage-pcs %p/Inputs/test-darwin_x86_64 |
> >> FileCheck %s --check-prefix=DARWIN
> >> +RUN: not sancov -print-coverage-pcs
> >> +%p/Inputs/test-linux_android_aarch64 2>&1 | FileCheck %s
> >> +--check-prefix=AARCH64
> >>
> >>  LINUX: 0x4e132b
> >>  LINUX: 0x4e1472
> >> @@ -57,3 +58,6 @@ DARWIN: 0x1000018e0
> >>  DARWIN: 0x100001906
> >>  DARWIN: 0x1000019dc
> >>  DARWIN: 0x100001a28
> >> +
> >> +AARCH64: Error: __sanitizer_cov* functions not found
> >> +
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> --
> Sanjoy Das
> http://playingwithpointers.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160815/7efa75fc/attachment.html>