<div dir="ltr">Sorry for the breakage. I have split the test in to with appropriate REQUIRES not to break bots without AArch64 compiled in.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 12, 2016 at 4:30 PM Sanjoy Das <<a href="mailto:sanjoy@playingwithpointers.com">sanjoy@playingwithpointers.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is failing on linux-x86_64 for me too -- perhaps this is missing a<br>
REQUIRES line?<br>
<br>
[697/697] Linking CXX executable bin/opt<br>
[126/126] Running the LLVM regression tests<br>
FAIL: LLVM :: tools/sancov/print_coverage_pcs.test (17650 of 17651)<br>
******************** TEST 'LLVM ::<br>
tools/sancov/print_coverage_pcs.test' FAILED ********************<br>
Script:<br>
--<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov<br>
-print-coverage-pcs<br>
/local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-linux_x86_64 |<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test<br>
--check-prefix=LINUX<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/llvm-objdump -d<br>
/local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-windows_x86_64 |<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test<br>
--check-prefix=DISAS_WIN<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov<br>
-print-coverage-pcs<br>
/local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-windows_x86_64 |<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test<br>
--check-prefix=WINDOWS<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov<br>
-print-coverage-pcs<br>
/local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-darwin_x86_64 |<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test<br>
--check-prefix=DARWIN<br>
not /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/sancov<br>
-print-coverage-pcs<br>
/local/sanjoy/llvm.git/test/tools/sancov/Inputs/test-linux_android_aarch64<br>
2>&1 | /local/sanjoy/llvm.git/build/debug+asserts-x86/./bin/FileCheck<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test<br>
--check-prefix=AARCH64<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
/local/sanjoy/llvm.git/test/tools/sancov/print_coverage_pcs.test:62:10:<br>
error: expected string not found in input<br>
AARCH64: Error: __sanitizer_cov* functions not found<br>
^<br>
<stdin>:1:1: note: scanning from here<br>
Error: No available targets are compatible with this triple.<br>
^<br>
<br>
--<br>
<br>
********************<br>
Testing Time: 89.35s<br>
********************<br>
Failing Tests (1):<br>
LLVM :: tools/sancov/print_coverage_pcs.test<br>
<br>
Expected Passes : 10703<br>
Expected Failures : 32<br>
Unsupported Tests : 6915<br>
Unexpected Failures: 1<br>
FAILED: cd /local/sanjoy/llvm.git/build/debug+asserts-x86/test &&<br>
/home/buildmaster/sw/python/2.7.3/linux/x86_64/bin/python2.7<br>
/local/sanjoy/llvm.git/utils/lit/lit.py -sv --param<br>
llvm_site_config=/local/sanjoy/llvm.git/build/debug+asserts-x86/test/lit.site.cfg<br>
--param llvm_unit_site_config=/local/sanjoy/llvm.git/build/debug+asserts-x86/test/Unit/lit.site.cfg<br>
/local/sanjoy/llvm.git/build/debug+asserts-x86/test<br>
ninja: build stopped: subcommand failed.<br>
<br>
On Fri, Aug 12, 2016 at 3:43 PM, Yung, Douglas via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Hi Mike,<br>
><br>
> This change is causing a failure on the PS4 bot with an error "No available targets are compatible with this triple." I suspect because the PS4 target only builds the x86 target, and then fails when trying to run this test and cannot find AArch64. Can you take a look into this issue?<br>
><br>
> Douglas Yung<br>
><br>
>> -----Original Message-----<br>
>> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On<br>
>> Behalf Of Mike Aizatsky via llvm-commits<br>
>> Sent: Friday, August 12, 2016 13:28<br>
>> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> Subject: [llvm] r278560 - [AArch64] Registering default MCInstrAnalysis<br>
>><br>
>> Author: aizatsky<br>
>> Date: Fri Aug 12 15:28:05 2016<br>
>> New Revision: 278560<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278560&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=278560&view=rev</a><br>
>> Log:<br>
>> [AArch64] Registering default MCInstrAnalysis<br>
>><br>
>> Even in this form it is useful: it can detect branch instructions.<br>
>><br>
>> <a href="https://github.com/google/sanitizers/issues/706" rel="noreferrer" target="_blank">https://github.com/google/sanitizers/issues/706</a><br>
>><br>
>> Subscribers: aemerson, rengolin<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D23426" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23426</a><br>
>><br>
>> Added:<br>
>> llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64<br>
>> Modified:<br>
>> llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp<br>
>> llvm/trunk/test/tools/sancov/print_coverage_pcs.test<br>
>><br>
>> Modified:<br>
>> llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
>> project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.<br>
>> cpp?rev=278560&r1=278559&r2=278560&view=diff<br>
>> =======================================================================<br>
>> =======<br>
>> --- llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp<br>
>> (original)<br>
>> +++ llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp<br>
>> +++ Fri Aug 12 15:28:05 2016<br>
>> @@ -15,6 +15,7 @@<br>
>> #include "AArch64ELFStreamer.h"<br>
>> #include "AArch64MCAsmInfo.h"<br>
>> #include "InstPrinter/AArch64InstPrinter.h"<br>
>> +#include "llvm/MC/MCInstrAnalysis.h"<br>
>> #include "llvm/MC/MCInstrInfo.h"<br>
>> #include "llvm/MC/MCRegisterInfo.h"<br>
>> #include "llvm/MC/MCStreamer.h"<br>
>> @@ -116,6 +117,10 @@ static MCStreamer *createMachOStreamer(M<br>
>> /*LabelSections*/ true); }<br>
>><br>
>> +static MCInstrAnalysis *createAArch64InstrAnalysis(const MCInstrInfo<br>
>> +*Info) {<br>
>> + return new MCInstrAnalysis(Info);<br>
>> +}<br>
>> +<br>
>> // Force static initialization.<br>
>> extern "C" void LLVMInitializeAArch64TargetMC() {<br>
>> for (Target *T :<br>
>> @@ -135,6 +140,9 @@ extern "C" void LLVMInitializeAArch64Tar<br>
>> // Register the MC subtarget info.<br>
>> TargetRegistry::RegisterMCSubtargetInfo(*T,<br>
>> createAArch64MCSubtargetInfo);<br>
>><br>
>> + // Register the MC instruction analyzer.<br>
>> + TargetRegistry::RegisterMCInstrAnalysis(*T,<br>
>> + createAArch64InstrAnalysis);<br>
>> +<br>
>> // Register the MC Code Emitter<br>
>> TargetRegistry::RegisterMCCodeEmitter(*T,<br>
>> createAArch64MCCodeEmitter);<br>
>><br>
>><br>
>> Added: llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
>> project/llvm/trunk/test/tools/sancov/Inputs/test-<br>
>> linux_android_aarch64?rev=278560&view=auto<br>
>> =======================================================================<br>
>> =======<br>
>> Binary files llvm/trunk/test/tools/sancov/Inputs/test-<br>
>> linux_android_aarch64 (added) and<br>
>> llvm/trunk/test/tools/sancov/Inputs/test-linux_android_aarch64 Fri Aug<br>
>> 12 15:28:05 2016 differ<br>
>><br>
>> Modified: llvm/trunk/test/tools/sancov/print_coverage_pcs.test<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
>> project/llvm/trunk/test/tools/sancov/print_coverage_pcs.test?rev=278560<br>
>> &r1=278559&r2=278560&view=diff<br>
>> =======================================================================<br>
>> =======<br>
>> --- llvm/trunk/test/tools/sancov/print_coverage_pcs.test (original)<br>
>> +++ llvm/trunk/test/tools/sancov/print_coverage_pcs.test Fri Aug 12<br>
>> +++ 15:28:05 2016<br>
>> @@ -3,6 +3,7 @@ RUN: sancov -print-coverage-pcs %p/Input<br>
>> RUN: llvm-objdump -d %p/Inputs/test-windows_x86_64 | FileCheck %s --<br>
>> check-prefix=DISAS_WIN<br>
>> RUN: sancov -print-coverage-pcs %p/Inputs/test-windows_x86_64 |<br>
>> FileCheck %s --check-prefix=WINDOWS<br>
>> RUN: sancov -print-coverage-pcs %p/Inputs/test-darwin_x86_64 |<br>
>> FileCheck %s --check-prefix=DARWIN<br>
>> +RUN: not sancov -print-coverage-pcs<br>
>> +%p/Inputs/test-linux_android_aarch64 2>&1 | FileCheck %s<br>
>> +--check-prefix=AARCH64<br>
>><br>
>> LINUX: 0x4e132b<br>
>> LINUX: 0x4e1472<br>
>> @@ -57,3 +58,6 @@ DARWIN: 0x1000018e0<br>
>> DARWIN: 0x100001906<br>
>> DARWIN: 0x1000019dc<br>
>> DARWIN: 0x100001a28<br>
>> +<br>
>> +AARCH64: Error: __sanitizer_cov* functions not found<br>
>> +<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
--<br>
Sanjoy Das<br>
<a href="http://playingwithpointers.com" rel="noreferrer" target="_blank">http://playingwithpointers.com</a><br>
</blockquote></div>