[PATCH] D23465: [PM] BitcodeWriterPass should derive from PassInfoMixin

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 14:38:08 PDT 2016


mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM. 
I'm not sure about the registration, I think right now it is only to be able to schedule pass from a string? This shouldn't apply this this pass.

TBH, I even wonder if having the bitcode writer as a pass is useful at all? (It does not really hurt keeping it though...)


https://reviews.llvm.org/D23465





More information about the llvm-commits mailing list