[PATCH] D23465: [PM] BitcodeWriterPass should derive from PassInfoMixin

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 14:34:25 PDT 2016


tejohnson updated this revision to Diff 67913.
tejohnson added a comment.

Remove name() method, which is not needed when deriving from Mixin


https://reviews.llvm.org/D23465

Files:
  include/llvm/Bitcode/BitcodeWriterPass.h

Index: include/llvm/Bitcode/BitcodeWriterPass.h
===================================================================
--- include/llvm/Bitcode/BitcodeWriterPass.h
+++ include/llvm/Bitcode/BitcodeWriterPass.h
@@ -44,7 +44,7 @@
 ///
 /// Note that this is intended for use with the new pass manager. To construct
 /// a pass for the legacy pass manager, use the function above.
-class BitcodeWriterPass {
+class BitcodeWriterPass : public PassInfoMixin<BitcodeWriterPass> {
   raw_ostream &OS;
   bool ShouldPreserveUseListOrder;
   bool EmitSummaryIndex;
@@ -68,8 +68,6 @@
   /// \brief Run the bitcode writer pass, and output the module to the selected
   /// output stream.
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &);
-
-  static StringRef name() { return "BitcodeWriterPass"; }
 };
 
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23465.67913.patch
Type: text/x-patch
Size: 805 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160812/ee38808b/attachment.bin>


More information about the llvm-commits mailing list