[PATCH] D20268: Resolution-based LTO API.

[Teresa Johnson via llvm-commits]

On Fri, Aug 12, 2016 at 6:54 AM, Teresa Johnson <tejohnson at google.com>
wrote:

>
>
> On Fri, Aug 12, 2016 at 1:07 AM, Roger Ferrer Ibanez <
> roger.ferreribanez at arm.com> wrote:
>
>> rogfer01 added a subscriber: rogfer01.
>>
>> ================
>> Comment at: llvm/trunk/tools/gold/gold-plugin.cpp:95
>> @@ +94,3 @@
>> +  bool VisibleToRegularObj = false;
>> +  uint64_t Size = 0;
>> +  unsigned Align = 0;
>> ----------------
>> I think this one should be `size_t` as `lto::InputFile::Symbol::getCommonSize`
>> returns `size_t` and then the `std::max` in line 629 fails to build in
>> targets where `size_t` is `unsigned int`.
>>
>> Can you confirm if changing to `size_t` makes sense here? It does fix the
>> build indeed.
>>
>
> Hi Roger,
>
> Sorry about that and thanks for suggesting a fix. I believe actgually taht
> getCommonSize should instead be changed to return uint64_t, since it
> returns the result of DataLayout::getTypeAllocSize which is uint64_t. Will
> commit that fix in a moment. Please let me know if this fixes your issue
> but I think it should.
>

 r278512

Teresa
>
>
>> If this is OK I can commit the change.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D20268
>>
>>
>>
>>
>
>
> --
> Teresa Johnson |  Software Engineer |  tejohnson at google.com |
> 408-460-2413
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160812/606c3292/attachment.html>