<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 12, 2016 at 6:54 AM, Teresa Johnson <span dir="ltr"><<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Fri, Aug 12, 2016 at 1:07 AM, Roger Ferrer Ibanez <span dir="ltr"><<a href="mailto:roger.ferreribanez@arm.com" target="_blank">roger.ferreribanez@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">rogfer01 added a subscriber: rogfer01.<br>
<br>
================<br>
Comment at: llvm/trunk/tools/gold/gold-plu<wbr>gin.cpp:95<br>
@@ +94,3 @@<br>
+  bool VisibleToRegularObj = false;<br>
+  uint64_t Size = 0;<br>
+  unsigned Align = 0;<br>
----------------<br>
I think this one should be `size_t` as `lto::InputFile::Symbol::getCo<wbr>mmonSize` returns `size_t` and then the `std::max` in line 629 fails to build in targets where `size_t` is `unsigned int`.<br>
<br>
Can you confirm if changing to `size_t` makes sense here? It does fix the build indeed.<br></blockquote><div><br></div></span><div>Hi Roger,</div><div><br></div><div>Sorry about that and thanks for suggesting a fix. I believe actgually taht getCommonSize should instead be changed to return uint64_t, since it returns the result of DataLayout::getTypeAllocSize which is uint64_t. Will commit that fix in a moment. Please let me know if this fixes your issue but I think it should.</div></div></div></div></blockquote><div><br></div><div> r278512</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Teresa</div><span class="gmail-"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
If this is OK I can commit the change.<br>
<div class="gmail-m_5120213444956397684HOEnZb"><div class="gmail-m_5120213444956397684h5"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D20268" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2026<wbr>8</a><br>
<br>
<br>
<br>
</div></div></blockquote></span></div><span class="gmail-HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_5120213444956397684gmail_signature"><span style="font-family:times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> <a href="tel:408-460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><span style="font-family:times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>